Patch for PR23472

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 3 13:16:18 PDT 2015


LGTM, but I would expand on the comment a bit:
     // The ABI says: "It is suggested that it be emitted in the same
COMDAT group
     // as the associated data object." In practice, this doesn't work for
non-ELF object formats, so only do it for ELF.

On Thu, Sep 3, 2015 at 11:31 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> I fully trust Reid review on this, so OK with me.
>
> On 3 September 2015 at 14:04, Yaron Keren <yaron.keren at gmail.com> wrote:
> > http://llvm.org/pr23472
> >
> > As suggested by Reid, OK to commit?
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150903/13680074/attachment.html>


More information about the cfe-commits mailing list