[PATCH] D12458: [clang] add __builtin_unpredictable and convert to metadata

[Krzysztof Parzyszek via cfe-commits]

kparzysz added a comment.

LGTM


================
Comment at: lib/CodeGen/CodeGenFunction.cpp:1238
@@ -1217,3 +1237,3 @@
   }
-  Builder.CreateCondBr(CondV, TrueBlock, FalseBlock, Weights);
+  Builder.CreateCondBr(CondV, TrueBlock, FalseBlock, Weights, Unpredictable);
 }
----------------
spatel wrote:
> spatel wrote:
> > kparzysz wrote:
> > > Is the definition of CreateCondBr actually updated somewhere?  I didn't see it in any other patch.
> > Yes - please see the 2nd hunk in IRBuilder.h in D12341.
> [the previous reply didn't make it to the commits list...trying again]
> Yes - please see the 2nd hunk in IRBuilder.h in D12341.
You're right.  I see it.


http://reviews.llvm.org/D12458