[PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

Andrey Bokhanko via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 31 06:48:23 PDT 2015


andreybokhanko added a comment.

In http://reviews.llvm.org/D11297#235525, @rjmccall wrote:

> Yes, please make it an error.


Done.

John, thank you for all your patience and explanations! -- I understand that this particular review and patch author required more than the usual measure. :-(

> And the obvious test changes are fine. :)


I asked because after switching from warning to error, I had to introduce a new run line in the test -- effectively transforming it into two.

Andrey


Repository:
  rL LLVM

http://reviews.llvm.org/D11297





More information about the cfe-commits mailing list