[PATCH] D12466: Fix empty -L Path on OSX hosts

Martell Malone via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 28 19:03:20 PDT 2015

martell created this revision.
martell added reviewers: rnk, yaron.keren.
martell added a subscriber: cfe-commits.
martell set the repository for this revision to rL LLVM.

Not quite sure if this is the proper way to fix this.
This is currently my work around when working from an OSX host though.

I think I need some feedback from either rnk or yaron on how to fix this.
I assume the path is supposed to be "." and not an empty string as it is on mac.
I can't reproduce this issue on linux or windows also.




Index: lib/Driver/Tools.cpp
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -9267,6 +9267,7 @@
   Args.AddAllArgs(CmdArgs, options::OPT_L);
   const ToolChain::path_list Paths = TC.getFilePaths();
   for (const auto &Path : Paths)
+      if(Path.length() > 0)
     CmdArgs.push_back(Args.MakeArgString(StringRef("-L") + Path));

   AddLinkerInputs(TC, Inputs, Args, CmdArgs);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12466.33510.patch
Type: text/x-patch
Size: 449 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150829/14197670/attachment.bin>

More information about the cfe-commits mailing list