[PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 27 14:29:11 PDT 2015


EricWF added a comment.

So this patch LGTM. Sorry for being slow to understand it. However I want to see two things before it lands.

1. I would like to see a test of some sort that the resulting type has the same size and alignment requirements it did before the change. I'm not sure what the best way to test this is.
2. I would like @mclow.lists to approve this as well. I just want to be cautious.


http://reviews.llvm.org/D12247





More information about the cfe-commits mailing list