[PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

Zhengkai Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 26 14:04:06 PDT 2015


zhengkai created this revision.
zhengkai added a reviewer: rtrieu.
zhengkai added a subscriber: cfe-commits.

Use a new algorithm to find map back the ranges to its spelling locations.

But the function is not working properly either, and it breaks a test.

In the last case in the test file /llvm/tools/clang/test/Misc/caret-diags-macros.c,
it underlined the wrong range. This is reported as a bug in https://llvm.org/bugs/show_bug.cgi?id=24592.

The methods which are used to map back the source locations in the macro expansions are questionable in the SourceManager Class.

http://reviews.llvm.org/D12379

Files:
  lib/Frontend/DiagnosticRenderer.cpp
  test/Index/fix-its.m
  test/Misc/caret-diags-macros.c
  test/Misc/serialized-diags.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12379.33244.patch
Type: text/x-patch
Size: 18127 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150826/67a113c9/attachment-0001.bin>


More information about the cfe-commits mailing list