[PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 26 12:26:46 PDT 2015


jroelofs added a comment.

the `addWarningFlagIfSupported` part of this patch LGTM.


================
Comment at: test/libcxx/compiler.py:88
@@ -87,1 +87,3 @@
 
+    def compileString(self, source, out=None, flags=[], env=None, cwd=None):
+        cmd = self.compileCmd('-', out, flags)
----------------
this looks unused to me.

================
Comment at: test/libcxx/compiler.py:105
@@ -98,1 +104,3 @@
 
+    def compileLinkString(self, source, out=None, flags=[], env=None, cwd=None):
+        cmd = self.compileLinkCmd('-', out, flags)
----------------
this looks unused to me.


http://reviews.llvm.org/D11333





More information about the cfe-commits mailing list