[PATCH] Fix out-of-bounds array access when setting arm float registers

[Saleem Abdulrasool via cfe-commits]

On Fri, Aug 21, 2015 at 11:02 AM, Hans Wennborg <hans at chromium.org> wrote:

> On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool
> <compnerd at compnerd.org> wrote:
> > On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg <hans at chromium.org>
> wrote:
> >>
> >> +Saleem and Renato; maybe you can take a look?
> >
> >
> > Thanks for pointing this out!
> >
> > The patch is correct and pretty safe to apply for 3.7 I think since its a
> > simple bug fix, and can result in VFP state corruption (the invalid
> memory
> > access in this case shouldn't access to arbitrary memory fortunately).
> I've
> > applied to trunk as SVN r245665.  Should I send a request on the thread
> for
> > the actual commit?
>
> It's too late to get this into 3.7.0, but it seems like a good
> candidate for 3.7.1. I'll put it on my list and we can merge it when
> Tom starts preparing the dot-release.
>

Sounds good to me.  Thanks.  If you can keep it on your list for 3.7.1,
that would be greatly appreciated.


> Thanks,
> Hans
>
>
> >> On Tue, Aug 18, 2015 at 11:24 AM, Leandro Graciá Gil
> >> <cfe-commits at lists.llvm.org> wrote:
> >> > Hi,
> >> >
> >> > Please find attached a patch fixing an out-of-bounds array access
> >> > present in
> >> > the current libunwind top of tree code.
> >> >
> >> > The problem is caused by subtracting the wrong base register in
> >> > Registers_arm::SetFloatRegister and should become obvious after
> taking a
> >> > quick look to the code.
> >> >
> >> > Could someone please commit this to trunk and merge it to the release
> 37
> >> > branch?
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150821/3a8189a3/attachment-0001.html>