[PATCH] Fix out-of-bounds array access when setting arm float registers

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 20 20:28:53 PDT 2015


On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg <hans at chromium.org> wrote:

> +Saleem and Renato; maybe you can take a look?


Thanks for pointing this out!

The patch is correct and pretty safe to apply for 3.7 I think since its a
simple bug fix, and can result in VFP state corruption (the invalid memory
access in this case shouldn't access to arbitrary memory fortunately).
I've applied to trunk as SVN r245665.  Should I send a request on the
thread for the actual commit?


> On Tue, Aug 18, 2015 at 11:24 AM, Leandro GraciĆ” Gil
> <cfe-commits at lists.llvm.org> wrote:
> > Hi,
> >
> > Please find attached a patch fixing an out-of-bounds array access
> present in
> > the current libunwind top of tree code.
> >
> > The problem is caused by subtracting the wrong base register in
> > Registers_arm::SetFloatRegister and should become obvious after taking a
> > quick look to the code.
> >
> > Could someone please commit this to trunk and merge it to the release 37
> > branch?
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150820/6b5ab34a/attachment.html>


More information about the cfe-commits mailing list