[PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: test/clang-tidy/arg-comments.cpp:1
@@ -1,3 +1,2 @@
-// RUN: $(dirname %s)/check_clang_tidy.sh %s misc-argument-comment %t
-// REQUIRES: shell
+// RUN: $(dirname %s)/check_clang_tidy.py %s misc-argument-comment %t
 
----------------
chapuni wrote:
> $(dirname %s) assumes shell. use %S instead.
> Lit internal runner is not capable of !shbang. use %python.
> 
>   // RUN: %python %S/check_clang_tidy.py %s misc-argument-comment %t
Sure, I should have noticed this. Thanks for pointing out!

================
Comment at: test/clang-tidy/google-readability-casting.c:7
@@ -6,3 +6,3 @@
 // RUN: clang-tidy --checks=-*,google-readability-casting -header-filter='.*' %t.main_file.cpp -- -I%S -DTEST_INCLUDE -x c++ | FileCheck %s -check-prefix=CHECK-MESSAGES -implicit-check-not='{{warning|error}}:'
 // REQUIRES: shell
 
----------------
chapuni wrote:
> It can be pruned.
Line 5 runs `cp`, will it work on Windows?


http://reviews.llvm.org/D12180