[clang-tools-extra] r245510 - Remove empty destructors added in r245500. I got confused by my

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 19 15:04:55 PDT 2015


Author: djasper
Date: Wed Aug 19 17:04:55 2015
New Revision: 245510

URL: http://llvm.org/viewvc/llvm-project?rev=245510&view=rev
Log:
Remove empty destructors added in r245500. I got confused by my
YouCompleteMe setup which apparently doesn't find the base classes and
thus doesn't understand that there is an implicit virtual destructor.

Modified:
    clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp

Modified: clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp?rev=245510&r1=245509&r2=245510&view=diff
==============================================================================
--- clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp (original)
+++ clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp Wed Aug 19 17:04:55 2015
@@ -31,7 +31,6 @@ class IncludeInserterCheckBase : public
 public:
   IncludeInserterCheckBase(StringRef CheckName, ClangTidyContext *Context)
       : ClangTidyCheck(CheckName, Context) {}
-  virtual ~IncludeInserterCheckBase() {}
 
   void registerPPCallbacks(CompilerInstance &Compiler) override {
     Inserter.reset(new IncludeInserter(Compiler.getSourceManager(),
@@ -66,7 +65,6 @@ class NonSystemHeaderInserterCheck : pub
 public:
   NonSystemHeaderInserterCheck(StringRef CheckName, ClangTidyContext *Context)
       : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~NonSystemHeaderInserterCheck() {}
 
   std::vector<StringRef> HeadersToInclude() const override {
     return {"path/to/header.h"};
@@ -78,7 +76,6 @@ class MultipleHeaderInserterCheck : publ
 public:
   MultipleHeaderInserterCheck(StringRef CheckName, ClangTidyContext *Context)
       : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~MultipleHeaderInserterCheck() {}
 
   std::vector<StringRef> HeadersToInclude() const override {
     return {"path/to/header.h", "path/to/header2.h", "path/to/header.h"};
@@ -90,7 +87,6 @@ class CSystemIncludeInserterCheck : publ
 public:
   CSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext *Context)
       : IncludeInserterCheckBase(CheckName, Context) {}
-  virtual ~CSystemIncludeInserterCheck() {}
 
   std::vector<StringRef> HeadersToInclude() const override {
     return {"stdlib.h"};




More information about the cfe-commits mailing list