[PATCH] D12002: Initial WebAssembly support in clang

[JF Bastien via cfe-commits]

jfb added a comment.

Still lgtm, with minor comments.


================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:364
@@ +363,3 @@
+    ItaniumCXXABI(CGM, /* UseARMMethodPtrABI = */ true,
+                  /* UseARMGuardVarABI = */ true) {}
+
----------------
It's more common to have no spaces for these comments: `/*UseARMMethodPtrABI=*/true,`.

================
Comment at: lib/Driver/Tools.cpp:1567
@@ +1566,3 @@
+
+#ifdef __wasm__
+    // Handle "native" by examining the host.
----------------
Could you expand a bit on why "native" doesn't make sense if LLVM itself wasn't compiled for wasm?


Repository:
  rL LLVM

http://reviews.llvm.org/D12002