[PATCH] D11781: Refactored pthread usage in libcxx

[Eric Fiselier via cfe-commits]

EricWF added a reviewer: EricWF.
EricWF added a comment.

This patch has a long way to go but it has also come a long way. Here are a couple of problems I see with it.

1. There are still plenty of ABI breaks. I'll try and point them all out.
2. This patch adds a lot of headers. libc++ has historically tried to keep the number of headers to a minimum for the reason that filesystem operations are expensive and its cheaper to include a few big headers as opposed to many small ones.
3. There where some subtle static initialization changes. However they may have been fixed.

I'll do a more through review soon.


================
Comment at: include/mutex:534
@@ -533,3 +516,3 @@
 
-_LIBCPP_FUNC_VIS void __call_once(volatile unsigned long&, void*, void(*)(void*));
 
----------------
This looks like an ABI break to me.


Repository:
  rL LLVM

http://reviews.llvm.org/D11781