[PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

Sjoerd Meijer via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 04:26:36 PDT 2015


Please see updated patch file attached, which now includes a fixed/added regression test.

Sjoerd.

 

From: Sjoerd Meijer 
Sent: 17 August 2015 13:34
To: 'Gabriel Dos Reis'; Richard Smith
Cc: Marshall Clow; cfe-commits
Subject: RE: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

 

Agreed, let’s get that right first.

The attached patch causes the program to trap for all optimizations levels, except when optimizing for size.

 

Sjoerd.

 

From: dosreis at gmail.com [mailto:dosreis at gmail.com] On Behalf Of Gabriel Dos Reis
Sent: 13 August 2015 21:51
To: Richard Smith
Cc: Sjoerd Meijer; Marshall Clow; cfe-commits
Subject: Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

 

Please make such programs crash early and often.  They are a nightmare to maintain.  Make them blow in the face of the original authors; not after they are gone.

 

-- Gaby

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150818/12189849/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Always-trap-for-missing-return-statements-except-whe.patch
Type: application/octet-stream
Size: 2273 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150818/12189849/attachment.obj>


More information about the cfe-commits mailing list