[PATCH] D12087: always_inline codegen rewrite

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 17 13:48:30 PDT 2015


eugenis marked an inline comment as done.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:447-448
@@ +446,4 @@
+    if (C && !isa<llvm::GlobalValue>(C)) {
+      C->handleOperandChange(GV, IndirectReplacement, &U);
+      continue;
+    }
----------------
Good catch.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:496
@@ +495,3 @@
+    CI->setAttributes(Fn->getAttributes());
+    if (FT->getReturnType()->isVoidTy())
+      llvm::ReturnInst::Create(Ctx, BB);
----------------
I don't see any difference from the current behavior. All lines inlined from F.inlinefunction to F are attrubuted directly to F, and inspecting debug info in the binary and IR I don't find any mentions of "inlinefunction".


http://reviews.llvm.org/D12087





More information about the cfe-commits mailing list