[PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

Aleksei Sidorin via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 16 03:35:18 PDT 2015


a.sidorin added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp:215-220
@@ +214,8 @@
+      return assumeSymWithinInclusiveRange(State, Sym, From, To, InRange);
+    return State;
+  } // end switch
+
+  case nonloc::ConcreteIntKind: {
+    const llvm::APSInt &IntVal = Value.castAs<nonloc::ConcreteInt>().getValue();
+    bool IsInRange = IntVal >= From && IntVal <= To;
+    bool isFeasible = (IsInRange == InRange);
----------------
jordan_rose wrote:
> This is still relevant.
Both types are equal for CaseStmt. But I'll check this code anyway because I found an interesting issue in CFG for SwitchStmt and I'm still investigating it.


http://reviews.llvm.org/D5102





More information about the cfe-commits mailing list