r245083 - Don't run explicit-modules-missing-files.cpp on Windows

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 14 12:03:02 PDT 2015

Author: rnk
Date: Fri Aug 14 14:03:02 2015
New Revision: 245083

URL: http://llvm.org/viewvc/llvm-project?rev=245083&view=rev
Don't run explicit-modules-missing-files.cpp on Windows

It is flaky due to inability to remove files with open handles.  We
could paper over it with rm -f, but then the file would still be

This is more evidence to me that we should roll our own 'rm'
implementation in LLVM.


Modified: cfe/trunk/test/Modules/explicit-build-missing-files.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/explicit-build-missing-files.cpp?rev=245083&r1=245082&r2=245083&view=diff
--- cfe/trunk/test/Modules/explicit-build-missing-files.cpp (original)
+++ cfe/trunk/test/Modules/explicit-build-missing-files.cpp Fri Aug 14 14:03:02 2015
@@ -27,6 +27,9 @@
 // RUN: rm %t/a.h
 // RUN: %clang_cc1 -fmodules -I %t -fmodule-file=%t/a.pcm %s -verify
+// Oftentimes on Windows there are open handles, and deletion will fail.
+// REQUIRES: can-remove-opened-file
 #include "a.h" // expected-error {{file not found}}
 int x = b;

More information about the cfe-commits mailing list