[clang-tools-extra] r245052 - [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/

[İsmail Dönmez via cfe-commits]

Hi,

On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: alexfh
> Date: Fri Aug 14 09:31:31 2015
> New Revision: 245052
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245052&view=rev
> Log:
> [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/
>
> This is better structurally and it also fixes a linker error in the configure
> build.

This seems to break cmake build on Linux:

FAILED: : && /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/clang++
-fPIC -fuse-ld=gold -stdlib=libc++ -fPIC -fvisibility-inlines-hidden
-Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wno-long-long
-Wcovered-switch-default -Wnon-virtual-dtor -Werror=date-time
-std=c++11 -fcolor-diagnostics -ffunction-sections -fdata-sections
-fno-common -Woverloaded-virtual -fno-strict-aliasing
-Wno-nested-anon-types -O2 -g  -stdlib=libc++ -Wl,-z,defs   -Wl,-O3
-Wl,--gc-sections -shared
-Wl,-soname,libclangTidyModernizeModule.so.3.8 -o
lib64/libclangTidyModernizeModule.so.3.8.0svn
tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/ModernizeTidyModule.cpp.o
tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/PassByValueCheck.cpp.o
 lib64/libclangAST.so.3.8.0svn lib64/libclangASTMatchers.so.3.8.0svn
lib64/libclangBasic.so.3.8.0svn lib64/libclangLex.so.3.8.0svn
lib64/libclangTidy.so.3.8.0svn
lib64/libclangTidyReadabilityModule.so.3.8.0svn
lib64/libLLVMSupport.so.3.8.0svn -Wl,-rpath,"\$ORIGIN/../lib64" && :
../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:169:
error: undefined reference to
'clang::tidy::IncludeInserter::IncludeInserter(clang::SourceManager
const&, clang::LangOptions const&,
clang::tidy::IncludeSorter::IncludeStyle)'
/home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
error: undefined reference to
'clang::tidy::IncludeInserter::~IncludeInserter()'
../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:171:
error: undefined reference to
'clang::tidy::IncludeInserter::CreatePPCallbacks()'
../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:215:
error: undefined reference to
'clang::tidy::IncludeInserter::CreateIncludeInsertion(clang::FileID,
llvm::StringRef, bool)'
/home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
error: undefined reference to
'clang::tidy::IncludeInserter::~IncludeInserter()'
/home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
error: undefined reference to
'clang::tidy::IncludeInserter::~IncludeInserter()'
clang-3.8: error: linker command failed with exit code 1 (use -v to
see invocation)