[PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.

Ivan Krasin via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 16:28:32 PDT 2015

krasin added a comment.

In http://reviews.llvm.org/D12021#224102, @pcc wrote:

> You could create a fake resource directory which contains only the `asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an example of this kind of thing.

I believe it's unnecessary. The default blacklists are handled in https://github.com/llvm-mirror/clang/blob/82a8792ad361e9443615fc81ee8dd37c76e64dbd/lib/Driver/SanitizerArgs.cpp#L82, and the code I added is in the frontend. The tests I am removing are not really testing that blacklists get into the deps. They test that default blacklists are explicitly passed from the toolchain to the frontend. If there's no such a test, I could add it in a separate CL.


More information about the cfe-commits mailing list