[PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 15:10:37 PDT 2015

rsmith added inline comments.

Comment at: include/clang/AST/ASTContext.h:180
@@ -179,3 +179,3 @@
   /// that appear in constant initializers to their evaluated values.
-  llvm::DenseMap<const MaterializeTemporaryExpr*, APValue>
+  std::map<const MaterializeTemporaryExpr *, APValue>
I would prefer a `DenseMap<const MaterializedTemporaryExpr*, APValue*>`, with `APValue`s allocated by the `ASTContext`'s `BumpPtrAllocator`.


More information about the cfe-commits mailing list