[PATCH] D11944: Nativize filename in FileManager::getFile().

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 10:50:26 PDT 2015

rsmith added a comment.

I would think most Windows users would be surprised if we showed them paths with /s instead of \s, but I'm fine with us using / internally if it doesn't leak out to the user.

klimek: if we want to nativize, I think the right thing to do is to remove the wrong "normalization" of non-Windows paths from `llvm::sys::path::native`, and add a more efficient overload to `llvm::sys::path::native`, such as `StringRef native(StringRef Input, SmallVectorImpl<char> &Buffer)`.


More information about the cfe-commits mailing list