[PATCH] D10365: Add cmd to compilation database file format

[Manuel Klimek via cfe-commits]

klimek added inline comments.

================
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:295
@@ +294,3 @@
+        if (CommandFound) {
+          ErrorMessage = "Multiple command and arguments found";
+          return false;
----------------
You're probably right. I guess people are not distributing clang tools (yet!), so we probably don't need tools like cmake to output both at the same time.

What I meant with "preferred" is that we could allow specifying both, and then we would use 'arguments', if specified, and otherwise fall back to 'command'. Does that make sense?

================
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:298-300
@@ +297,5 @@
+        }
+        for (auto& NextArgument : *SequenceString) {
+          SmallString<128> CommandStorage;
+          auto ValueString = dyn_cast<llvm::yaml::ScalarNode>(&NextArgument);
+
----------------
Thanks!


http://reviews.llvm.org/D10365