[PATCH] D11963: Create a __config_site file to capture configuration decisions.
Jonathan Roelofs via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 12 07:19:27 PDT 2015
jroelofs added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation - for every program that we compile.
> > However, this may be the right thing to do.
> I'm with Jonathan here, having config params dealt with this way it's easier and make things more manageable while the price of a slowdown, I think, shouldn't be substantial.
Another option would be to rename `__config` to `__config.in`, and put the `#cmakedefine` lines in here. Then the include tree isn't changed.
Comment at: test/std/atomics/libcpp-has-no-threads.pass.cpp:11
@@ -10,1 +10,3 @@
> This is not the right include file.
> How about "#include <ciso646>", which defined in the standard (to do nothing), but includes "<__config>"
> Really, this test doesn't belong in test/std/, but in test/libcxx, but this change didn't put it there.
I think it'd be better for me to just move the test. What is <ciso646> supposed to be for?
More information about the cfe-commits