[PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

Daniel Marjamäki via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 11:24:23 PDT 2015


danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.

In http://reviews.llvm.org/D11940#221718, @thakis wrote:

> Can't you just change your signature to
>
>   virtual void a(int /* x */) {}
>   
>
> in these cases?


hmm.. yes I agree.

You are right, so I change my mind about this patch.


http://reviews.llvm.org/D11940





More information about the cfe-commits mailing list