[PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 10 08:22:31 PDT 2015


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: tools/driver/driver.cpp:464-466
@@ +463,5 @@
+                                           PrependedOpts);
+      // Insert right after the program name to prepend to the argument list.
+      for (const char *PrependedOpt : PrependedOpts)
+        argv.insert(argv.begin() + 1, AdjustOpt(PrependedOpt));
+    }
----------------
How about adjusting all the options in place and then inserting them all at once to avoid the N^2 complexity?


http://reviews.llvm.org/D11896





More information about the cfe-commits mailing list