[PATCH] D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange

[Nathan Wilson via cfe-commits]

nwilson added inline comments.

================
Comment at: lib/Sema/SemaDecl.cpp:7454-7456
@@ +7453,5 @@
+              PDiag(diag::err_function_concept_exception_spec);
+          if (Range.isValid()) {
+            PD << FixItHint::CreateRemoval(Range);
+          }
+          Diag(NewFD->getLocation(), PD);
----------------
rsmith wrote:
> You don't need this `if`; a `FixItHint` with an invalid range has no effect.
Ahhh, okay. I misunderstood the original comment about an empty SourceRange apparently.

I'll go back to using Diagnostic rather than PartialDiagnostic as well.




http://reviews.llvm.org/D11789