[PATCH] D11753: [X86] Add support for _MM_ALIGN16

Eric Christopher echristo at gmail.com
Wed Aug 5 12:50:18 PDT 2015


echristo added inline comments.

================
Comment at: test/CodeGen/ms-mm-align.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
+// RUN:         -triple i686--windows -Oz -emit-llvm %s -o - \
----------------
mkuper wrote:
> echristo wrote:
> > Any chance of putting thi with the rest of the Intrin.h checks?
> I've originally wanted to put it in ms-intinsics.c, but it fails for the "-triple thumbv7--windows" test (as it should - this is an x86-only macro).
> If you have a different test in mind, I'll move it there.
No that seems reasonable.

================
Comment at: test/CodeGen/ms-mm-align.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
+// RUN:         -triple i686--windows -Oz -emit-llvm %s -o - \
+// RUN:         | FileCheck %s -check-prefix CHECK
----------------
mkuper wrote:
> echristo wrote:
> > Shouldn't need -Oz.
> Copied that from ms-intrinsics.c as well. Will remove.
Feel free to remove it from the other file as well.


http://reviews.llvm.org/D11753





More information about the cfe-commits mailing list