[PATCH] D11743: [CMake] First pass at adding support for clang bootstrap builds to CMake

Chandler Carruth chandlerc at gmail.com
Wed Aug 5 10:00:41 PDT 2015


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Totally awesome man, ship it. I've left a nit-pick below, but this is definitely the right starting place.


================
Comment at: CMakeLists.txt:615
@@ +614,3 @@
+
+  set(ADDITIONAL_TARGETS_TO_ADD check check-all)
+  foreach(target ${ADDITIONAL_TARGETS_TO_ADD})
----------------
nit pick: I'd call it 'check-llvm', 'check-clang', and 'check-all'. I'm OK if we have to hard code the list though, that seems a minor inconvenience.


http://reviews.llvm.org/D11743





More information about the cfe-commits mailing list