[PATCH] D11613: repress tail call optimization when performing use-after-dtor sanitization

Evgeniy Stepanov eugenis at google.com
Thu Jul 30 10:35:44 PDT 2015


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: test/CodeGenCXX/sanitize-dtor-tail-call.cpp:17
@@ +16,3 @@
+// Simple internal member is poisoned by compiler-generated dtor
+// CHECK: define {{.*}}SimpleD2Ev{{.*}} [[ATTRIBUTE:#[0-9]]]
+// CHECK: {{^ *}}call void @__sanitizer_dtor_callback
----------------
#[0-9]+
Just in case.


================
Comment at: test/CodeGenCXX/sanitize-dtor-tail-call.cpp:19
@@ +18,3 @@
+// CHECK: {{^ *}}call void @__sanitizer_dtor_callback
+// CHECK-NOT: tail call void @__sanitizer_dtor_callback
+// CHECK: ret void
----------------
Remove "tail".
That way this will check that there is no other call to the dtor callback, tail or not.



http://reviews.llvm.org/D11613







More information about the cfe-commits mailing list