[PATCH] D11483: [libcxxabi][mips] Correct float_data::mangled_size for all ABI's.

Hans Wennborg hans at chromium.org
Thu Jul 30 07:09:00 PDT 2015

hans added a comment.

In http://reviews.llvm.org/D11483#215120, @dsanders wrote:

> > I'd like to LGTM this on the basis
> Scratch that. I'm one of the authors (albeit as a minor revision on Jaydeep+Nitesh's patch) and I can't approve my own patches :-).
> Hans: Are you willing to LGTM it?

I don't know enough here to be a good review. What's mangled_size used for?

In http://reviews.llvm.org/D11483#215133, @mclow.lists wrote:

> I have no objections to this change; but I have no way to test it.

Is that an lgtm or call for some kind of test? :-)


More information about the cfe-commits mailing list