r243602 - Remove bad test.

Sean Silva chisophugis at gmail.com
Wed Jul 29 18:21:56 PDT 2015


Author: silvas
Date: Wed Jul 29 20:21:56 2015
New Revision: 243602

URL: http://llvm.org/viewvc/llvm-project?rev=243602&view=rev
Log:
Remove bad test.

We currently don't canonicalize paths in the preprocessed files.
But we do when writing to PCH.
This causes a discrepancy on Windows with the test below.
This test fails even on unix if you change the test to use
`%S//preprocess.h`.

I am led to conclude that the invariant that this test was intending to
test has not been upheld for a while (and may never have been).

Removed:
    cfe/trunk/test/PCH/preprocess.c
    cfe/trunk/test/PCH/preprocess.h

Removed: cfe/trunk/test/PCH/preprocess.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/PCH/preprocess.c?rev=243601&view=auto
==============================================================================
--- cfe/trunk/test/PCH/preprocess.c (original)
+++ cfe/trunk/test/PCH/preprocess.c (removed)
@@ -1,8 +0,0 @@
-// Check that -E mode is invariant when using an implicit PCH.
-
-// RUN: %clang_cc1 -include %S/preprocess.h -E -o %t.orig %s
-// RUN: %clang_cc1 -emit-pch -o %t %S/preprocess.h
-// RUN: %clang_cc1 -include-pch %t -E -o %t.from_pch %s
-// RUN: diff %t.orig %t.from_pch
-
-a_typedef a_value;

Removed: cfe/trunk/test/PCH/preprocess.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/PCH/preprocess.h?rev=243601&view=auto
==============================================================================
--- cfe/trunk/test/PCH/preprocess.h (original)
+++ cfe/trunk/test/PCH/preprocess.h (removed)
@@ -1,7 +0,0 @@
-// Helper header for preprocess.c PCH test
-#ifndef PREPROCESS_H
-#define PREPROCESS_H
-
-typedef int a_typedef;
-
-#endif // PREPROCESS_H





More information about the cfe-commits mailing list