[PATCH] D11555: [libcxx] Allow use of <atomic> in C++03. Try 3.

Marshall Clow mclow.lists at gmail.com
Wed Jul 29 09:35:09 PDT 2015

mclow.lists added a comment.

In general, this is looking quite good.

Comment at: include/ios:373
@@ -371,2 +372,3 @@
+#if defined(_LIBCPP_HAS_C_ATOMIC_IMP) && !defined(_LIBCPP_HAS_NO_THREADS)
     static atomic<int> __xindex_;
Do you need to address this TODO before committing? (and the one in <memory> ?)

Comment at: test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_helpers.h:41
@@ +40,3 @@
+    test<wchar_t>()
+#define TEST_EACH_ATOMIC_TYPE()   \
Is there a way to do this w/o exposing the name `test` here?
Maybe a type list and then apply-ing to to each member of the type list?


More information about the cfe-commits mailing list