[PATCH] D11594: Fix NAME.1 comdat name for replaced GlobalVariable

Reid Kleckner rnk at google.com
Wed Jul 29 08:24:14 PDT 2015

rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with slightly tighter test case.

Comment at: tools/clang/test/CodeGenCXX/vtable-key-function-win-comdat.cpp:18
@@ +17,2 @@
+// CHECK:     $_ZTS6Test1a = comdat any
+// CHECK-NOT: $_ZTI6Test1a.1 = comdat any
Can you also CHECK that the vtable definition has the right name, linkage, and uses this comdat?



More information about the cfe-commits mailing list