[PATCH] D11046: [libcxx] Add Atomic test helper and fix TSAN failures.

Eric Fiselier eric at efcs.ca
Tue Jul 28 10:24:35 PDT 2015


EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D11046#203989, @mclow.lists wrote:

> Should these tests go into the `std/` hierarchy, or the `libcxx/` hierarchy?


They belong in `std/`.  There is a remark on each of the following `wait*` methods that states

> [thread.condition.condvarany]

>  Postcondition: lock.owns_lock() is true and lock.mutex() is locked by the calling thread.

>  Remarks: If the function fails to meet the postcondition, std::terminate() shall be called



http://reviews.llvm.org/D11046







More information about the cfe-commits mailing list