[PATCH] D1623: Support __builtin_ms_va_list.

Reid Kleckner rnk at google.com
Mon Jul 27 14:30:27 PDT 2015


rnk added inline comments.

================
Comment at: include/clang/AST/Expr.h:3724-3726
@@ -3722,3 +3723,5 @@
 
-  TypeSourceInfo *getWrittenTypeInfo() const { return TInfo; }
-  void setWrittenTypeInfo(TypeSourceInfo *TI) { TInfo = TI; }
+  /// Returns whether this is really a Win64 ABI va_arg expression.
+  bool isMicrosoftABI() const { return TInfo.getInt(); }
+  void setIsMicrosoftABI(bool IsMS) { TInfo.setInt(IsMS); }
+
----------------
This seems unfortunate. Richard, why do we even have a VAArgExpr instead of just leaving it as a builtin CallExpr like __builtin_va_start? Just history?


http://reviews.llvm.org/D1623







More information about the cfe-commits mailing list