[PATCH] D11504: Split -Wmicrosoft into many detailed warnings.

Reid Kleckner rnk at google.com
Mon Jul 27 10:46:52 PDT 2015

rnk added a comment.

This feels too fine-grained to me, but I could be convinced either way. Someone somewhere will probably be thankful that they can turn off *just* -Wmicrosoft-void-pseudo-destructor. @majnemer, what do you think?

Comment at: include/clang/Basic/DiagnosticGroups.td:722
@@ +721,3 @@
+def MicrosoftFixedEnum : DiagGroup<"microsoft-fixed-enum">;
+def MicrosoftExceptionEllipsis : DiagGroup<"microsoft-exception-ellipsis">;
+def MicrosoftSealed : DiagGroup<"microsoft-sealed">;
I think we can merge this with MicrosoftExceptionSpec, they are both about EH specification relaxations.

Comment at: include/clang/Basic/DiagnosticGroups.td:724
@@ +723,3 @@
+def MicrosoftSealed : DiagGroup<"microsoft-sealed">;
+def MicrosoftPragmaComment : DiagGroup<"microsoft-pragma-comment">;
+def MicrosoftUnqualifiedFriend : DiagGroup<"microsoft-unqualified-friend">;
Let's kill this, we can use the -Wignored-pragmas group for it.

Comment at: include/clang/Basic/DiagnosticParseKinds.td:944
@@ -943,3 +943,3 @@
 def warn_pragma_comment_ignored : Warning<"'#pragma comment %0' ignored">,
-  InGroup<Microsoft>;
+  InGroup<MicrosoftPragmaComment>;
 // - #pragma detect_mismatch
Let's put this in the IgnoredPragmas group.


More information about the cfe-commits mailing list