[PATCH] D10423: [modules] PR20507: Avoid silent textual inclusion.

Sean Silva chisophugis at gmail.com
Mon Jul 20 14:49:08 PDT 2015


silvas updated this revision to Diff 30196.
silvas added a comment.

Updating based on Richard's feedback.

Richard, is this something like you imagined?

The PPCallbacks is still not being called, like the existing branch
`// We hit an error processing the import. Bail out.`. The fix will be
similar for both, so this at least isn't making it any harder to fix the
situation.


http://reviews.llvm.org/D10423

Files:
  include/clang/Basic/DiagnosticCommonKinds.td
  include/clang/Basic/DiagnosticFrontendKinds.td
  include/clang/Basic/DiagnosticLexKinds.td
  lib/Lex/ModuleMap.cpp
  lib/Lex/PPDirectives.cpp
  test/Modules/Inputs/auto-import-unavailable/missing_header/not_missing.h
  test/Modules/Inputs/auto-import-unavailable/missing_requirement.h
  test/Modules/Inputs/auto-import-unavailable/module.modulemap
  test/Modules/Inputs/auto-import-unavailable/nonrequired_missing_header/not_missing.h
  test/Modules/Inputs/auto-import-unavailable/nonrequired_missing_header/requires_feature_you_dont_have.h
  test/Modules/Inputs/available-is-better/available-is-better.h
  test/Modules/Inputs/available-is-better/module.modulemap
  test/Modules/Inputs/declare-use/module.map
  test/Modules/Inputs/macro-reexport/module.modulemap
  test/Modules/auto-import-unavailable.cpp
  test/Modules/available-is-better.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10423.30196.patch
Type: text/x-patch
Size: 11468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150720/524615f9/attachment.bin>


More information about the cfe-commits mailing list