[PATCH] D11207: Enable recognition of __declspec for PS4

[Reid Kleckner]

rnk added inline comments.

================
Comment at: include/clang/Basic/LangOptions.def:81
@@ -80,2 +80,3 @@
 LANGOPT(ObjC2             , 1, 0, "Objective-C 2")
+LANGOPT(SceExt            , 1, 0, "Sony PlayStation(R) extensions")
 BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0,
----------------
dberlin wrote:
> silvas wrote:
> > wristow wrote:
> > > rnk wrote:
> > > > How do you guys feel about "sony" vs. "sce"? I know we abbreviated Microsoft to MS, but I think a lot of folks don't know that the full name of the particular company involved is "Sony Computer Entertainment". If -fsce-extensions is already used in build systems, I'm OK leaving the flag as is. I'm mostly concerned with SceExt.
> > > We do already have '-target x86_64-scei-ps4', and we have other pending changes that use 'sce' (rather than 'scei') that I expect will appear very soon.  So we (Sony) are leaning toward continuing with 'sce'.
> > "Sony" is way too broad. The company "Sony" does everything from image sensors to banking & insurance to lithium batteries to public transit turnstiles to laparoscopic surgery equipment. We don't represent the entire company "Sony", nor is there any reason to believe that anything we are doing applies to "Sony" as a whole.
> Please don't use (R) here. It should be unnecessary (and we don't do it for others).
Sounds like it's going to be SCE, then. Would it be accurate to put "Sony Computer Entertainment extensions" in the comment, since that's what's being abbreviated?


http://reviews.llvm.org/D11207