[PATCH] D10536: [X86, inlineasm] Implement v, k, Y2, Yk, Yz constraints, improve analysis for x, Y*, L, e, Z, s

Alexey Frolov alexfrolov1878 at yandex.ru
Fri Jul 17 05:52:00 PDT 2015


alexfrol added a comment.

In http://reviews.llvm.org/D10536#203421, @compnerd wrote:

> LGTM with the small change to rename isValidAsmValue at least.


All issues are fixed. I'll update the patch soon.

In http://reviews.llvm.org/D10536#203820, @echristo wrote:

> This will need documentation updates yes? Also backend support?
>
> -eric


What documentation updates do you mean?
Backend support is necessary for ‘v’, ‘k’, and ‘Yk’ constraints. They are AVX-512 specific and as far as I know work for AVX512 backend support is still ongoing.

In http://reviews.llvm.org/D10536#203821, @echristo wrote:

> I don't see a test for the 'k' support or a few other things either. Can you split this out a bit into the various parts for checking the existing constraints, and adding individual ones?
>
> -eric


Sure, will do.


Repository:
  rL LLVM

http://reviews.llvm.org/D10536







More information about the cfe-commits mailing list