[PATCH] D11229: [clang-cl] Use the Windows response file tokenizer

Hans Wennborg hans at chromium.org
Wed Jul 15 13:47:30 PDT 2015


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm!


================
Comment at: tools/driver/driver.cpp:400
@@ +399,3 @@
+  // -cc1 tools don't care which tokenization mode we use, because response
+  // files written by clang will tokenize the same way in either mode.
+  llvm::cl::TokenizerCallback Tokenizer = &llvm::cl::TokenizeGNUCommandLine;
----------------
Maybe expand this comment pointing out that we're checking for --driver-mode manually here because it's very early and we don't know the mode yet, like you said in the change description.


http://reviews.llvm.org/D11229







More information about the cfe-commits mailing list