[PATCH] AST matcher for exception variables

Aaron Ballman aaron at aaronballman.com
Wed Jul 15 10:12:20 PDT 2015


On Wed, Jul 15, 2015 at 1:01 PM, Manuel Klimek <klimek at google.com> wrote:
> Ah, sorry for the delay (you could help me by using phab - but no worries,
> small changes like this are easy enough).

No worries on the delay, this wasn't particularly pressing. :-)

> I'd name the thing isExceptionVariable, as that's also the method we're
> calling on the AST.
> Apart from that LGTM

Thank you for the suggestion, I've implemented it in r242303.

~Aaron

>
> On Wed, Jul 15, 2015 at 6:34 PM Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> Ping
>>
>> ~Aaron
>>
>> On Fri, Jul 10, 2015 at 3:15 PM, Aaron Ballman <aaron at aaronballman.com>
>> wrote:
>> > There is not currently a way to match against a variable declaration
>> > that is an exception variable. For instance:
>> >
>> > void f() {
>> >   try {
>> >     int X;
>> >   } catch (int Y) {
>> >   }
>> > }
>> >
>> > You can match int X and int Y, but you cannot currently match only int
>> > Y. The attached patch adds a matcher to allow that, as well as test
>> > code and documentation.
>> >
>> > ~Aaron



More information about the cfe-commits mailing list