[PATCH] D11092: use-after-dtor cmd option

Evgeniy Stepanov eugenis at google.com
Thu Jul 9 22:09:17 PDT 2015


eugenis added inline comments.

================
Comment at: lib/CodeGen/CGClass.cpp:1459
@@ +1458,3 @@
+
+  if (CGM.getCodeGenOpts().SanitizeMemoryUseAfterDtor) {
+    // insert destructor clean up here
----------------
Please remove this block completely. It does nothing.

================
Comment at: lib/Driver/SanitizerArgs.cpp:420
@@ -418,1 +419,3 @@
       }
+      MsanUseAfterDtor =
+          Args.hasArg(options::OPT_fsanitize_memory_use_after_dtor);
----------------
It looks like this variable is only assigned but never read.

================
Comment at: test/Driver/fsanitize.c:126
@@ +125,3 @@
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=memory -fsanitize-memory-use-after-dtor -pie %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-USE-AFTER-DTOR-0
+// CHECK-MSAN-USE-AFTER-DTOR-0: -fsanitize-memory-use-after-dtor
+
----------------
remove "-0"


http://reviews.llvm.org/D11092







More information about the cfe-commits mailing list