[PATCH] D10609: Mostly standardize on "MumbleToolChain" as the ToolChain subclass name. NFC

Richard Smith richard at metafoo.co.uk
Wed Jul 8 14:21:46 PDT 2015


rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM

Chandler, do you still want to take another look at this?


================
Comment at: lib/Driver/ToolChains.h:845-847
@@ -843,5 +844,5 @@
 
-/// SHAVEToolChain - A tool chain using the compiler installed by the the
+// SHAVEToolChain - A tool chain using the compiler installed by the the
 // Movidius SDK into MV_TOOLS_DIR (which we assume will be copied to llvm's
 // installation dir) to perform all subcommands.
 class LLVM_LIBRARY_VISIBILITY SHAVEToolChain : public Generic_GCC {
----------------
These should be `///` comments. Also, while you're touching this line, typo "the the". (And maybe commit this hunk separately.)


http://reviews.llvm.org/D10609







More information about the cfe-commits mailing list