[PATCH] D10700: Driver: Add AMDGPU toolchain

Douglas Katzman dougk at google.com
Mon Jul 6 07:52:58 PDT 2015


dougk added a subscriber: dougk.

================
Comment at: lib/Driver/ToolChains.h:726
@@ -725,1 +725,3 @@
 
+class LLVM_LIBRARY_VISIBILITY AMDGPU_TC : public Generic_ELF {
+protected:
----------------
Please use ToolChain instead of _TC as the suffix.
See http://reviews.llvm.org/D10609 (pending) which standardizes on that.

================
Comment at: lib/Driver/Tools.cpp:5759
@@ +5758,3 @@
+  CmdArgs.push_back("-target");
+  CmdArgs.push_back("amdgcn--");
+  AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs);
----------------
any reason not to insert getToolChain().getTripleString() vs hardcoding 'amdgcn--' ?


http://reviews.llvm.org/D10700







More information about the cfe-commits mailing list