r241343 - - Refactored ARMTargetInfo in order to use the API of llvm/lib/Support/TargetParser.cpp

Renato Golin renato.golin at linaro.org
Fri Jul 3 09:44:26 PDT 2015


On 3 July 2015 at 12:57, Alexandros Lamprineas
<alexandros.lamprineas at arm.com> wrote:
> Author: alelab01
> Date: Fri Jul  3 06:57:23 2015
> New Revision: 241343
>
> URL: http://llvm.org/viewvc/llvm-project?rev=241343&view=rev
> Log:
> - Refactored ARMTargetInfo in order to use the API of llvm/lib/Support/TargetParser.cpp
>   for extracting target specific information.
> - Patch for commit 241267: ShouldUseInlineAtomic was set incorrectly when subArch was
>   not specified, causing regressions.

Hi Alexandros,

This was breaking all buildbots again. I hope you've got an ARM box
somewhere to run a "make check-all" and make sure that your next
attempt doesn't break the build on at least x86_64 and ARM.

Now, thinking about that instability of the atomics and Thumb flags, I
believe you'll have to get to the bottom of that to fix it once and
for all.

I reverted the patch for now.

cheers,
--renato



More information about the cfe-commits mailing list