[PATCH] code refactoring on ARMTargetInfo class

Renato Golin renato.golin at linaro.org
Thu Jul 2 03:50:36 PDT 2015


In http://reviews.llvm.org/D10839#198411, @labrinea wrote:

> Ok, fair enough. Thanks again for the feedback :) I am currently trying to replace some of the if-else statements in getDefaultFeatures() that extract FPU information based on the CPU. I am adding a helper function in TargetParser for that. It maps CPU names to FPUKinds. Shall I commit the current patch first, or altogether?


I think you should commit this small fix now, and then refactor it later if needed, with your next patch.

Thanks!


http://reviews.llvm.org/D10839

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list