[PATCH] Add missing atomic libcall support.

James Y Knight jyknight at google.com
Tue Jun 30 13:02:45 PDT 2015


================
Comment at: lib/CodeGen/CGAtomic.cpp:811-815
@@ +810,7 @@
+
+    case AtomicExpr::AO__c11_atomic_load:
+    case AtomicExpr::AO__c11_atomic_store:
+    case AtomicExpr::AO__c11_atomic_exchange:
+    case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
+    case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
+    case AtomicExpr::AO__atomic_load_n:
----------------
majnemer wrote:
> Do any of the tests cover this part of the change?
None of the new ones do, but also note that this part is not a change in behavior, just changing from "default:" to listing all the options not listed above, so that missing a case emits a warning.

These calls are at least mostly covered by other tests, although I did not audit them to ensure 100% coverage.

http://reviews.llvm.org/D10847

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list