[PATCH] missing the consideration of calling conversion in around 81 clang regression tests.

[Ying Yi]

Hello David,

Many thanks for your help.

Regards

Ying Yi

On Mon, Jun 29, 2015 at 6:38 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Sure thing - committed in r240971
>
> On Mon, Jun 29, 2015 at 3:50 AM, Ying Yi <maggieyi666 at gmail.com> wrote:
>
>> Hello David,
>>
>>
>> Many thanks for your comments. When I modified the regression tests to
>> add the calling conventions, I considered using “{{\w*}}” as well. However,
>> I found some tests with calling conventions that used {{.*}}. Therefore, I
>> have used {{.*}} to make the tests consistent. I hope this is ok.
>>
>>
>> I don’t have commit access at the moment since this patch is my first
>> patch to cfe-commits. As mentioned in
>> http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch,
>> the commit access is granted to contributors with a track record of
>> submitting high quality patches.
>>
>>
>> Could you please help me by committing this patch or advise what do I
>> need to do in order to commit this change?
>>
>>
>> Many thanks,
>>
>> Ying Yi
>>
>>
>> On Fri, Jun 26, 2015 at 5:24 PM, David Blaikie <dblaikie at gmail.com>
>> wrote:
>>
>>> Looks good to me, please commit.
>>>
>>> (optionally, if you could put a space in the regex, that might not hurt:
>>>
>>>   define {{.* }}void
>>>
>>> maybe even:
>>>
>>>   define {{\w* }}void
>>>
>>> So it only accepts one token and doesn't accidentally eat more things.
>>> Probably not terribly important and maybe what you have is the better
>>> readability/accuracy tradeoff anyway.)
>>>
>>> On Fri, Jun 26, 2015 at 2:16 AM, Maggie Yi <maggieyi666 at gmail.com>
>>> wrote:
>>>
>>>> Dear All,
>>>>
>>>> I would like to propose a patch for clang regression tests that will
>>>> fail on targets that set specific calling conventions.
>>>>
>>>> For example, in Clang :: CodeGen/builtinshufflevector2.c:
>>>>
>>>>          Expected IR:
>>>>
>>>>                          "define void @clang_shufflevector_v_v"
>>>>
>>>>          IR generated with a default triple of armv7a_pc_linux:
>>>>
>>>>                          "define arm_aapcs void
>>>> @clang_shufflevector_v_v"
>>>>
>>>>         The test could be changed to expect "define{{.*}} void
>>>> @clang_shufflevector_v_v".
>>>>
>>>> For ARM target with default triple armv7a_pc_linux, around 81 clang
>>>> regression tests failed due to the same reason.
>>>>
>>>> It includes CodeGen, CodeGenCXX, CodeGenObjC, CodeGenObjCXX,
>>>> CodeGenOpenCL, Modules, OpenMP,
>>>> PCH, Profile and Sema tests. Please see attached the patch file for
>>>> the details.
>>>>
>>>> Please let me know if this is an acceptable change.
>>>>
>>>>
>>>> Kind Regards,
>>>>
>>>>
>>>> Ying
>>>>
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>>
>>>>
>>>
>>
>>
>> --
>> Ying Yi
>> SN Systems Ltd - Sony Computer Entertainment Group.
>>
>
>


-- 
Ying Yi
SN Systems Ltd - Sony Computer Entertainment Group.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150630/a7a58057/attachment.html>