[PATCH] Implement shared_mutex re: N4508

Marshall Clow mclow.lists at gmail.com
Mon Jun 29 13:52:42 PDT 2015


> Can apple take this patch since it adds new symbols to the dylib?


I believe that they're OK with that; I'll give them a heads-up.


================
Comment at: include/shared_mutex:196
@@ +195,3 @@
+
+//     typedef __shared_mutex_base::native_handle_type native_handle_type;
+//     _LIBCPP_INLINE_VISIBILITY native_handle_type native_handle() { return __base::unlock_shared(); }
----------------
EricWF wrote:
> mclow.lists wrote:
> > EricWF wrote:
> > > Why are these commented out/not getting committed?
> > In the standard, they are optional.
> Why comment them out though? Either we should ship them or remove them. 
I'm fine with that.

http://reviews.llvm.org/D10480

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list