[PATCH] Fix crash-on-invalid bug in template instantiation.

Meador Inge meadori at gmail.com
Thu Jun 25 13:23:09 PDT 2015


This fix LGTM, but I do wonder about one thing.  The following pattern seems to occur all over `Sema`:

  InstantiatingTemplate Inst(*this, PointOfInstantiation, Decl);
    if (Inst.isInvalid())
      ...

For example, in `Sema::InstantiateEnum`.  Why aren't we marking decls invalid in those other places?


http://reviews.llvm.org/D10622

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list